fixes: add error check for SSL_set_tlsext_status_type#374
Merged
zhuizhuhaomeng merged 2 commits intoopenresty:masterfrom Jun 21, 2025
Merged
fixes: add error check for SSL_set_tlsext_status_type#374zhuizhuhaomeng merged 2 commits intoopenresty:masterfrom
zhuizhuhaomeng merged 2 commits intoopenresty:masterfrom
Conversation
fb21ae2 to
3b8978c
Compare
zhuizhuhaomeng
approved these changes
Jun 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Svace static analysis tool identified a potential issue in the function
ngx_stream_lua_socket_tcp_sslhandshake. The call toSSL_set_tlsext_status_type()was made without checking its return value.This can lead to a situation where OCSP stapling fails silently, possibly resulting in an incomplete TLS configuration.
The fix adds an explicit check for the return value of
SSL_set_tlsext_status_type(). If the function returns error, a Lua error is raised